Skip to content

fix(select): use non transparent inline select background#9138

Merged
sstrubberg merged 2 commits into
carbon-design-system:mainfrom
emyarod:9112-dark-theme-select-backgrounds
Jul 9, 2021
Merged

fix(select): use non transparent inline select background#9138
sstrubberg merged 2 commits into
carbon-design-system:mainfrom
emyarod:9112-dark-theme-select-backgrounds

Conversation

@emyarod

@emyarod emyarod commented Jul 7, 2021

Copy link
Copy Markdown
Member

Closes #9112

This PR sets a ui-background color for inline selects so that themed select options on Windows will be visible (Alternatively we can set explicit values on the select options and optgroups but the menus themselves may still be discolored because of how different OS and browser combinations handle menu rendering and CSS custom properties)

Testing / Reviewing

Confirm that the select options and option groups are visible on dark Carbon themes in all browser and OS combinations

@emyarod emyarod requested a review from a team as a code owner July 7, 2021 15:59
@emyarod emyarod requested review from dakahn and sstrubberg July 7, 2021 15:59
@netlify

netlify Bot commented Jul 7, 2021 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e875db0013d400074e0bea

@netlify

netlify Bot commented Jul 7, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e875dbb42e73000746c058

😎 Browse the preview: https://deploy-preview-9138--carbon-elements.netlify.app

@netlify

netlify Bot commented Jul 7, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 25a2ff5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e875db64c4540007533879

😎 Browse the preview: https://deploy-preview-9138--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Jul 8, 2021
View reviewed changes

@tw15egan tw15egan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tw15egan tw15egan requested review from a team and kingtraceyj and removed request for a team July 8, 2021 18:05
@sstrubberg sstrubberg enabled auto-merge (squash) July 9, 2021 16:13
@sstrubberg sstrubberg merged commit 129a7a4 into carbon-design-system:main Jul 9, 2021
@emyarod emyarod deleted the 9112-dark-theme-select-backgrounds branch July 9, 2021 16:48
@emyarod emyarod mentioned this pull request Jul 12, 2021
Closed
62 tasks
@tw15egan tw15egan mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstrubberg sstrubberg Awaiting requested review from sstrubberg

@kingtraceyj kingtraceyj Awaiting requested review from kingtraceyj

3 more reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: one more review 👀 status: visual review 🔍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inline Select component needs background in Chrome/Windows

5 participants

@emyarod @joshblack @tw15egan @dakahn @sstrubberg