feat(Modal): implement support for 3 button modals#7775
Merged
kodiakhq[bot] merged 11 commits intoFeb 19, 2021
Conversation
|
Deploy preview for carbon-elements ready! Built with commit fcc0143 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit fcc0143 https://deploy-preview-7775--carbon-components-react.netlify.app |
Contributor
Member
Author
819b9ca to
1bb7ece
Compare
Member
Author
|
modified button text vertical alignment for 3 button modals only after discussion with @aagonzales |
aagonzales
approved these changes
Feb 11, 2021
aagonzales
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing the button text. Looks good!
tw15egan
reviewed
Feb 12, 2021
Contributor
|
Looks really great! Do you think we can add a quick blurb to the |
1bb7ece to
3dfdc1d
Compare
joshblack
approved these changes
Feb 15, 2021
cb9a3d0 to
58713ff
Compare
341d4cc to
2ef643a
Compare
62 tasks
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



(tests will be updated when we have confirmed if the API changes are good to go)
--
Related #4607
This PR adds support for 3 button modals according to the latest modal spec. Since our existing Modal API expects only 1 primary and 1 secondary button, a
secondaryButtonsprop is introduced which can be used in place of thesecondaryButtonTextandonSecondarySubmitprops. ThesecondaryButtonsprop expects an array of up to 2 objects with the following shape:if an
onClickhandler is not supplied to the secondary buttons in aComposedModalit will fall back to the internalhandleRequestClosemethod by defaultChangelog
New
secondaryButtonspropTesting / Reviewing
Confirm the 3 button modal styles appear correct and there are no visual regressions with existing supported modal styles