fix(search): update search landmark labeling to use aria-labelledby#22347
Merged
kennylam merged 4 commits intoJun 1, 2026
Merged
Conversation
aria-labelledby
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22347 +/- ##
==========================================
- Coverage 95.53% 95.50% -0.03%
==========================================
Files 582 582
Lines 50472 50472
Branches 6810 6785 -25
==========================================
- Hits 48218 48204 -14
- Misses 2121 2135 +14
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…x/search-component-a11y-fixes
devadula-nandan
approved these changes
Jun 1, 2026
Merged
via the queue into
carbon-design-system:main
with commit Jun 1, 2026
37dff96
39 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12360
This changes the search landmark to use
aria-labelledbyinstead ofaria-label. The new reference points to the existinglabelelement that contains the requiredlabelTextprop. This approach enforces unique labels andlabelTextvalues for each search component used on the page.Changelog
New
Changed
aria-labelledbyrather thanaria-labelTesting / Reviewing
Searchstory<div role="search">hasaria-labelledbypointing to the label's IDaria-labelledbyvaluePR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examplesMore details can be found in the pull request guide