feat(code-connect): add support for cds-button#22295
Merged
riddhybansal merged 3 commits intoMay 22, 2026
Merged
Conversation
cds-button
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22295 +/- ##
==========================================
- Coverage 95.52% 95.49% -0.03%
==========================================
Files 582 582
Lines 50441 50441
Branches 6801 6801
==========================================
- Hits 48182 48171 -11
- Misses 2126 2137 +11
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
heloiselui
approved these changes
May 21, 2026
heloiselui
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just need to resolve the conflicts.
riddhybansal
approved these changes
May 22, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 22, 2026
054231e
40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22255
Adds Figma Code Connect support for
cds-button. Also fixes a small bug in React where the2xlsize would not show in Code Connect panel.Updates
@figma/code-connectto the latest version1.4.5Changelog
New
cds-buttonChanged
2xlsize in the React versionTesting / Reviewing
Link: https://www.figma.com/design/NwXsMCCoMg1po4KK2oUK3o/Code-connect-demo---Carbon-Design-System?node-id=219-60349&m=dev
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistency