feat: Added sm and md sizes for contained tabs#22288
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alina-jacob
left a comment
There was a problem hiding this comment.
Thanks for working on this @riddhybansal!
Looks good to me! 🚀
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22288 +/- ##
==========================================
- Coverage 95.53% 95.51% -0.03%
==========================================
Files 582 582
Lines 50409 50410 +1
Branches 6797 6787 -10
==========================================
- Hits 48158 48148 -10
- Misses 2119 2130 +11
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02c12ea
|
Hey there! v11.108.0 was just released that references this issue/PR. |
Closes #21598
Added sm and md sizes for contained tabs in both react and web components.
Changelog
New
Changed
Removed
Testing / Reviewing
Test all contained tabs have a prop size with sm, md and lg options and they should work as per the spec mentioned in the issue in both react and web components
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request guide