Skip to content

feat: Added sm and md sizes for contained tabs#22288

Merged
maradwan26 merged 3 commits into
carbon-design-system:mainfrom
riddhybansal:contained_tabs_size
May 19, 2026
Merged

feat: Added sm and md sizes for contained tabs#22288
maradwan26 merged 3 commits into
carbon-design-system:mainfrom
riddhybansal:contained_tabs_size

Conversation

@riddhybansal

@riddhybansal riddhybansal commented May 19, 2026

Copy link
Copy Markdown
Contributor

Closes #21598

Added sm and md sizes for contained tabs in both react and web components.

Changelog

New

  • Added sm and md sizes for contained tabs in both react and web components.

Changed

  • NA

Removed

  • NA

Testing / Reviewing

Test all contained tabs have a prop size with sm, md and lg options and they should work as per the spec mentioned in the issue in both react and web components

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@riddhybansal riddhybansal requested a review from a team as a code owner May 19, 2026 09:43
@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c37ea30
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a0c30b26f70e7000832d98e
😎 Deploy Preview https://deploy-preview-22288--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c37ea30
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a0c30b2b751ce0008f2d6a7
😎 Deploy Preview https://deploy-preview-22288--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0513e66
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a0c314c2dcba90008466c12
😎 Deploy Preview https://deploy-preview-22288--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0513e66
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a0c314ca8b44000085ebf4a
😎 Deploy Preview https://deploy-preview-22288--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@riddhybansal riddhybansal requested review from a team and alina-jacob and removed request for a team May 19, 2026 09:50
@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0513e66
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a0c314c9a73dc00087c4fcc
😎 Deploy Preview https://deploy-preview-22288--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@alina-jacob alina-jacob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @riddhybansal!
Looks good to me! 🚀

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (3a7a06c) to head (0513e66).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22288      +/-   ##
==========================================
- Coverage   95.53%   95.51%   -0.03%     
==========================================
  Files         582      582              
  Lines       50409    50410       +1     
  Branches     6797     6787      -10     
==========================================
- Hits        48158    48148      -10     
- Misses       2119     2130      +11     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.24% <100.00%> (+<0.01%) ⬆️
web-components 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26 maradwan26 added this pull request to the merge queue May 19, 2026
Merged via the queue into carbon-design-system:main with commit 02c12ea May 19, 2026
58 of 62 checks passed
@carbon-automation

Copy link
Copy Markdown
Contributor

Hey there! v11.108.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Condensed components] Contained tabs: Implementation

4 participants