Skip to content

fix: avoid stale FloatingMenu position updates#22284

Merged
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:22276-floaties
May 21, 2026
Merged

fix: avoid stale FloatingMenu position updates#22284
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:22276-floaties

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Closes #22276

Avoided stale FloatingMenu position updates.

Changelog

Changed

  • Avoided stale FloatingMenu position updates.

Testing / Reviewing

Despite an existing pull request already being open for this issue, I'm opening a new one. I'm not sure the changes in the existing pull request are appropriate, and I don’t see a response to the concern raised here: #22277 (comment).

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@adamalston adamalston requested a review from a team as a code owner May 18, 2026 19:51
@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c86e28b
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a0b6db31f64520008ea31e4
😎 Deploy Preview https://deploy-preview-22284--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c86e28b
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a0b6db336e3bc00083d8f69
😎 Deploy Preview https://deploy-preview-22284--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c86e28b
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a0b6db3db12f00009fad055
😎 Deploy Preview https://deploy-preview-22284--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (463edd5) to head (c86e28b).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22284      +/-   ##
==========================================
- Coverage   95.51%   95.49%   -0.03%     
==========================================
  Files         582      582              
  Lines       50399    50401       +2     
  Branches     6763     6788      +25     
==========================================
- Hits        48141    48130      -11     
- Misses       2126     2139      +13     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.18% <100.00%> (+<0.01%) ⬆️
web-components 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heloiselui heloiselui added this pull request to the merge queue May 21, 2026
Merged via the queue into carbon-design-system:main with commit 47ec1aa May 21, 2026
40 of 41 checks passed
@adamalston adamalston deleted the 22276-floaties branch May 21, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: OverflowMenu enters update loop and crashes UI on viewport resize

3 participants