fix(inlinecheckbox): export inlinecheckbox#22263
Merged
heloiselui merged 7 commits intoMay 21, 2026
Merged
Conversation
For some reason InlineCheckbox is not publicly exported, although InlineCheckboxProps is. Our code has been importing it like: import InlineCheckbox from '@carbon/react/lib/components/InlineCheckbox'; but of course that's not proper. Refs #562 (because that's where InlineCheckbox was added).
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22263 +/- ##
==========================================
- Coverage 95.53% 95.51% -0.03%
==========================================
Files 582 582
Lines 50435 50435
Branches 6743 6743
==========================================
- Hits 48183 48171 -12
- Misses 2120 2132 +12
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emyarod
approved these changes
May 15, 2026
sangeethababu9223
approved these changes
May 18, 2026
sangeethababu9223
left a comment
Member
There was a problem hiding this comment.
Looks good. Once the snapshots are updated, I think this can be merged.
Contributor
Author
Ah you're right. Updated in a7a33a3. |
riddhybansal
approved these changes
May 20, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2026
649a988
40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #562 (because that's where InlineCheckbox was added).
Export
InlineCheckbox.For some reason
InlineCheckboxwas not publicly exported, even though it's in the same directory as all the other public components, and even thoughInlineCheckboxPropsis publicly exported. Is it supposed to be public?Our code has been importing it like:
But of course, that's not proper.
Changelog
New
Testing / Reviewing
Just the automated test. There's no Storybook for InlineCheckbox.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide