Skip to content

feat(link): add web components Link mapping and align Link type variants#22253

Merged
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
heloiselui:22251-code-connect-wc-link
May 14, 2026
Merged

feat(link): add web components Link mapping and align Link type variants#22253
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
heloiselui:22251-code-connect-wc-link

Conversation

@heloiselui

@heloiselui heloiselui commented May 13, 2026

Copy link
Copy Markdown
Contributor

Closes #22251

Add Figma Code Connect support for Carbon Web Components Link, align Link type mapping parity across React and Web Components, and fix React renderIcon typing for Code Connect instance mapping.

Changelog

New

  • Added a new Code Connect file for Web Components Link: packages/web-components/code-connect/link/link.figma.ts
  • Connected cds-link to the Carbon Figma node with mapped props (Type, Link text, Swap icon, Size, State)

Changed

Removed

  • None

Testing / Reviewing

Figma demo

In React we don't have the type error anymore
image

image

Web components, we can see that is available in Figma now:
image

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@heloiselui heloiselui requested a review from a team as a code owner May 13, 2026 12:20
@heloiselui heloiselui added the area: code-connect Issues relating to Figma Code Connect label May 13, 2026
@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fab6dc6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a049f1ef5b594000820426c
😎 Deploy Preview https://deploy-preview-22253--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit fab6dc6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a049f1e6db659000982d01c
😎 Deploy Preview https://deploy-preview-22253--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fab6dc6
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a049f1edb59de0008647aed
😎 Deploy Preview https://deploy-preview-22253--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (a0df9d4) to head (fab6dc6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22253      +/-   ##
==========================================
- Coverage   95.51%   95.49%   -0.03%     
==========================================
  Files         582      582              
  Lines       50320    50320              
  Branches     6769     6769              
==========================================
- Hits        48063    48052      -11     
- Misses       2125     2136      +11     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.18% <ø> (ø)
web-components 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue May 14, 2026
Merged via the queue into carbon-design-system:main with commit 02b5595 May 14, 2026
40 checks passed
@heloiselui heloiselui deleted the 22251-code-connect-wc-link branch May 14, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: code-connect Issues relating to Figma Code Connect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Connect: Web Components - Link

3 participants