Skip to content

chore(chromatic): remove g90 theme from snapshots#22243

Merged
maradwan26 merged 2 commits into
carbon-design-system:mainfrom
tay1orjones:task/reduce-theme-snaps
May 13, 2026
Merged

chore(chromatic): remove g90 theme from snapshots#22243
maradwan26 merged 2 commits into
carbon-design-system:mainfrom
tay1orjones:task/reduce-theme-snaps

Conversation

@tay1orjones

Copy link
Copy Markdown
Member

Suggestion from @jeffchew, this should reduce chromatic snapshot usage a bit to avoid hitting quota. g90 is barely used and an acceptable risk to remove from vrt.

Changelog

New

  • story-level g90 snapshot opt in docs

Changed

  • storybook config no longer snapshots g90

Testing / Reviewing

  • Storybook toolbar at the top of the canvas should still have the theme switcher and allow you to view stuff in g90
  • Chromatic status check should show that g90 snaps are "changed" or "removed"

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
    - [ ] Wrote passing tests that cover this change
    - [ ] Addressed any impact on accessibility (a11y)
    - [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@tay1orjones tay1orjones self-assigned this May 12, 2026
@tay1orjones tay1orjones requested a review from a team as a code owner May 12, 2026 18:26
@github-project-automation github-project-automation Bot moved this to 🕵️‍♀️ Triage in Design System May 12, 2026
@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to 🚦 In Review in Design System May 12, 2026
@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 392f273
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a047c7adf363f0008763d64
😎 Deploy Preview https://deploy-preview-22243--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 392f273
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a047c7a7b93a20008c4b5db
😎 Deploy Preview https://deploy-preview-22243--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 392f273
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a047c7a5f17ce0008623b90
😎 Deploy Preview https://deploy-preview-22243--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (e21e19a) to head (392f273).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22243   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         582      582           
  Lines       50320    50320           
  Branches     6769     6767    -2     
=======================================
  Hits        48051    48051           
  Misses       2137     2137           
  Partials      132      132           
Flag Coverage Δ
main-packages 89.18% <ø> (ø)
web-components 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devadula-nandan devadula-nandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26 maradwan26 added this pull request to the merge queue May 13, 2026
Merged via the queue into carbon-design-system:main with commit 6dc4a35 May 13, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from 🚦 In Review to ✅ Done in Design System May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants