Skip to content

refactor: extract MultiSelect select-all item helper for reuse#22206

Merged
sangeethababu9223 merged 2 commits into
carbon-design-system:mainfrom
adamalston:20452-select-all
May 15, 2026
Merged

refactor: extract MultiSelect select-all item helper for reuse#22206
sangeethababu9223 merged 2 commits into
carbon-design-system:mainfrom
adamalston:20452-select-all

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Partially addresses #20452

Extracted the MultiSelect select-all item helper for reuse.

Changelog

Changed

  • Extracted the MultiSelect select-all item helper for reuse.

Testing / Reviewing

Existing tests should cover these changes.

yarn test packages/react

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0c58664
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a03845dd99f97000805396c
😎 Deploy Preview https://deploy-preview-22206--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0c58664
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a03845daf012b00089d6f1f
😎 Deploy Preview https://deploy-preview-22206--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0c58664
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a03845dfe5f730008beeb99
😎 Deploy Preview https://deploy-preview-22206--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (4ac71d0) to head (0c58664).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22206      +/-   ##
==========================================
- Coverage   95.49%   95.49%   -0.01%     
==========================================
  Files         582      582              
  Lines       50320    50320              
  Branches     6742     6714      -28     
==========================================
- Hits        48053    48052       -1     
- Misses       2135     2136       +1     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.18% <100.00%> (ø)
web-components 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui

Copy link
Copy Markdown
Contributor

Hi @adamalston, could merge the latest changes from main into this branch?

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue May 15, 2026
Merged via the queue into carbon-design-system:main with commit aa1c85a May 15, 2026
40 checks passed
@adamalston adamalston deleted the 20452-select-all branch May 15, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants