refactor: remove stale no-console eslint links#22205
Merged
Merged
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22205 +/- ##
==========================================
- Coverage 95.49% 95.49% -0.01%
==========================================
Files 582 582
Lines 50320 50320
Branches 6742 6742
==========================================
- Hits 48053 48051 -2
- Misses 2135 2137 +2
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devadula-nandan
approved these changes
May 13, 2026
devadula-nandan
left a comment
Contributor
There was a problem hiding this comment.
LGTM
These console looks essential and doesn't need to be removed as per 20452 IMO.
Merged
via the queue into
carbon-design-system:main
with commit May 13, 2026
93b1978
56 of 57 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #20452
Removed stale
no-consoleESLint links.Changelog
Removed
no-consoleESLint links.Testing / Reviewing
The other option I considered was removing the
consoleusage. However, I've seen suggestions in past pull requests to keep them. Given that, I've removed the issue links so that the comments aren't suggesting that something needs to be changed. If something should be changed, let me know.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide