Skip to content

feat(code-connect): sync Button with extra small size mapping#22203

Merged
heloiselui merged 2 commits into
carbon-design-system:mainfrom
heloiselui:code-connect-xs-button-size
May 8, 2026
Merged

feat(code-connect): sync Button with extra small size mapping#22203
heloiselui merged 2 commits into
carbon-design-system:mainfrom
heloiselui:code-connect-xs-button-size

Conversation

@heloiselui

Copy link
Copy Markdown
Contributor

Closes #19571

Sync Code Connect to include the extra small button size of the component in React.

Changelog

New

  • Added Extra small > xs mapping to Button Figma Code Connect.
  • Added Extra small > xs mapping to ButtonSkeleton Figma Code Connect.

Changed

  • Updated packages/react/code-connect/Button/Button.figma.tsx size enums to include the new extra small option.

Removed

  • None

Testing / Reviewing

image

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@heloiselui heloiselui requested a review from a team as a code owner May 7, 2026 15:23
@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d8fde50
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69fcdb4f42747b0008f93281
😎 Deploy Preview https://deploy-preview-22203--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d8fde50
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69fcdb4f4a8dcf0008910893
😎 Deploy Preview https://deploy-preview-22203--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d8fde50
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/69fcdb4ffe81c200084586a3
😎 Deploy Preview https://deploy-preview-22203--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (38ca66c) to head (d8fde50).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22203   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         549      549           
  Lines       45645    45645           
  Branches     6556     6556           
=======================================
  Hits        43413    43413           
  Misses       2102     2102           
  Partials      130      130           
Flag Coverage Δ
main-packages 89.16% <ø> (ø)
web-components 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Image

@riddhybansal riddhybansal added this pull request to the merge queue May 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 8, 2026
@heloiselui heloiselui added this pull request to the merge queue May 8, 2026
Merged via the queue into carbon-design-system:main with commit d42808a May 8, 2026
40 checks passed
@heloiselui heloiselui deleted the code-connect-xs-button-size branch May 8, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Extra small button] Figma Code Connect sync

3 participants