chore: revert overflowmenu child typing#22197
Merged
tay1orjones merged 5 commits intoMay 7, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
maradwan26
approved these changes
May 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22197 +/- ##
==========================================
- Coverage 95.11% 95.10% -0.01%
==========================================
Files 549 549
Lines 45644 45645 +1
Branches 6528 6556 +28
==========================================
- Hits 43413 43412 -1
- Misses 2101 2103 +2
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
heloiselui
approved these changes
May 6, 2026
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adamalston
approved these changes
May 7, 2026
…y1orjones/carbon into task/revert-overflowmenu-child-typing
Member
Author
|
Looks like |
Merged
via the queue into
carbon-design-system:main
with commit May 7, 2026
38ca66c
40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the OverflowMenu child item cloning behavior change made in #22011
This broke a consumer so I've also added a test that covers this use case to ensure we don't break it again.
Changelog
New
Changed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Updated documentation and storybook examples- [ ] Addressed any impact on accessibility (a11y)- [ ] Tested for cross-browser consistencyMore details can be found in the pull request guide