Skip to content

fix(inline-loading): add or update live control args#22189

Merged
heloiselui merged 8 commits into
carbon-design-system:mainfrom
irsalsss:docs/inline-loading-add-args
May 18, 2026
Merged

fix(inline-loading): add or update live control args#22189
heloiselui merged 8 commits into
carbon-design-system:mainfrom
irsalsss:docs/inline-loading-add-args

Conversation

@irsalsss

@irsalsss irsalsss commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #20930

  • update live control args to InlineLoading stories

Changelog

Changed

  • updates docs and missing information

Testing / Reviewing

  • Go to InlineLoading in Storybook
  • Select `default story
  • Verify that all controls work.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@irsalsss irsalsss requested a review from a team as a code owner May 6, 2026 03:36
@irsalsss irsalsss requested review from maradwan26 and tay1orjones May 6, 2026 03:36
@github-actions

github-actions Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 99790b5
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a03f88d8644820008220bbe
😎 Deploy Preview https://deploy-preview-22189--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 99790b5
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a03f88df9ca1c0008d09e8c
😎 Deploy Preview https://deploy-preview-22189--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@irsalsss irsalsss changed the title fix(InlineLoading): update args fix(inline-loading): add or update live args May 6, 2026
@irsalsss irsalsss changed the title fix(inline-loading): add or update live args fix(inline-loading): add or update live control args May 6, 2026
@irsalsss

irsalsss commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 99790b5
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a03f88dcca06600083576b2
😎 Deploy Preview https://deploy-preview-22189--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

maradwan26
maradwan26 requested changes May 11, 2026
View reviewed changes

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Can you align the controls in the Web Components storybook as well?:

  • "assistive text" is deprecated so the control should be removed
  • Could use some cleaning up as well, "successDelay" can be removed

Comment thread packages/react/src/components/InlineLoading/InlineLoading.stories.js Outdated
@codecov

codecov Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (4ac71d0) to head (99790b5).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22189      +/-   ##
==========================================
- Coverage   95.49%   95.49%   -0.01%     
==========================================
  Files         582      582              
  Lines       50320    50320              
  Branches     6742     6710      -32     
==========================================
- Hits        48053    48052       -1     
- Misses       2135     2136       +1     
  Partials      132      132
Flag Coverage Δ
main-packages 89.18% <ø> (ø)
web-components 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

maradwan26
maradwan26 requested changes May 12, 2026
View reviewed changes
Comment thread packages/react/src/components/InlineLoading/InlineLoading.stories.js
Comment thread packages/web-components/src/components/inline-loading/inline-loading.ts
@irsalsss

irsalsss commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@maradwan26 my apologies, I got a bit ahead of myself and forgot to run the tests before pushing. Thank you for catching these bugs.

maradwan26
maradwan26 approved these changes May 13, 2026
View reviewed changes

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! LGTM 🚀

heloiselui
heloiselui approved these changes May 18, 2026
View reviewed changes

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heloiselui heloiselui added this pull request to the merge queue May 18, 2026
Merged via the queue into carbon-design-system:main with commit fbcc53b May 18, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heloiselui heloiselui heloiselui approved these changes

@maradwan26 maradwan26 maradwan26 approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/monorepo-reviewers

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[InlineLoading]: add controls args to every story

3 participants

@irsalsss @heloiselui @maradwan26