Skip to content

fix: associate DataTable TableCells with column headers#22169

Merged
heloiselui merged 2 commits into
carbon-design-system:mainfrom
adamalston:14263-associate
May 27, 2026
Merged

fix: associate DataTable TableCells with column headers#22169
heloiselui merged 2 commits into
carbon-design-system:mainfrom
adamalston:14263-associate

Conversation

@adamalston

@adamalston adamalston commented May 4, 2026

Copy link
Copy Markdown
Contributor

Closes #14263

Associated DataTable TableCells with column headers.

Changelog

New

  • Associated DataTable TableCells with column headers.

Testing / Reviewing

I wrote should associate data cells with their column headers to cover the fix. I also wrote should preserve custom header and cell associations to verify that the fix doesn't break override behavior since I didn't see existing coverage. When you revert the fix and run the tests, only should associate data cells with their column headers should fail.

yarn test packages/react/src/components/DataTable

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 18cd1fe
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a03d67986448200081b4685
😎 Deploy Preview https://deploy-preview-22169--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 18cd1fe
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a03d679e956d6000785131e
😎 Deploy Preview https://deploy-preview-22169--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (4ac71d0) to head (18cd1fe).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22169      +/-   ##
==========================================
- Coverage   95.49%   95.49%   -0.01%     
==========================================
  Files         582      582              
  Lines       50320    50328       +8     
  Branches     6742     6782      +40     
==========================================
+ Hits        48053    48059       +6     
- Misses       2135     2137       +2     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.18% <100.00%> (+<0.01%) ⬆️
web-components 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 18cd1fe
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a03d6797ef66400074e7ebe
😎 Deploy Preview https://deploy-preview-22169--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heloiselui heloiselui added this pull request to the merge queue May 27, 2026
Merged via the queue into carbon-design-system:main with commit feca786 May 27, 2026
55 of 56 checks passed
@adamalston adamalston deleted the 14263-associate branch May 27, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: DataTable [dynamic] - keyboard nav bug

3 participants