feat: migrate @carbon/themes to TypeScript#22166
Merged
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22166 +/- ##
==========================================
- Coverage 95.53% 95.40% -0.14%
==========================================
Files 582 551 -31
Lines 50472 48624 -1848
Branches 6808 6745 -63
==========================================
- Hits 48218 46389 -1829
+ Misses 2121 2110 -11
+ Partials 133 125 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tay1orjones
reviewed
May 21, 2026
| getTokenSet(name: string) { | ||
| for (const child of this) { | ||
| if (!child.kind === 'TokenSet') { | ||
| // TODO: Is this code necessary given the old code was invalid? |
Member
There was a problem hiding this comment.
You mean because the old condition
if (!child.kind === 'TokenSet') {
was invalid due to child.kind being typecasted to a boolean so this would always be true/false === 'TokenSet', which always resolves as false?
true === 'TokenSet'
// false
false === 'TokenSet'
// also false
Contributor
Author
There was a problem hiding this comment.
Yea, the boolean conversion breaking the comparison.
tay1orjones
approved these changes
May 21, 2026
maradwan26
approved these changes
May 22, 2026
riddhybansal
approved these changes
May 27, 2026
Merged
via the queue into
carbon-design-system:main
with commit Jun 1, 2026
7363e14
39 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Migrated
@carbon/themesto TypeScript.Changelog
New
@carbon/themesto TypeScript.@carbon/themes.@types/colorto resolve type errors.Testing / Reviewing
Build the package and check the types it emits.
I'm curious to know if anyone has more information about the
TODO. I'm not sure whether I'm missing some context.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request guide