fix: use controls exclude for fixed story props#22163
Merged
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22163 +/- ##
==========================================
- Coverage 95.10% 95.10% -0.01%
==========================================
Files 548 548
Lines 45599 45599
Branches 6582 6520 -62
==========================================
- Hits 43367 43366 -1
- Misses 2102 2103 +1
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
maradwan26
reviewed
May 4, 2026
maradwan26
left a comment
Contributor
There was a problem hiding this comment.
The Definition Tooltip stories in React can use some cleaning up, too. WithLargeText is trying to hide controls that are already being excluded .
maradwan26
approved these changes
May 5, 2026
kennylam
approved these changes
May 5, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 5, 2026
2830de7
38 checks passed
Contributor
|
Hey there! v11.107.0 was just released that references this issue/PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue. #22008 (comment)
Used
parameters.controls.excludefor fixed story props instead ofargTypes.table.disable.Changelog
Changed
parameters.controls.excludefor fixed story props instead ofargTypes.table.disable.Testing / Reviewing
I updated the Storybook stories to use
parameters.controls.excludefor props that are fixed by the story and only need to be hidden from the Controls panel. I kept, what seemed to be, intentionally undocumented, deprecated, or otherwise unusable props onargTypes.table.disable.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide