fix: restore modal launcher focus for MenuButton refs#22161
Merged
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22161 +/- ##
==========================================
+ Coverage 95.10% 95.12% +0.02%
==========================================
Files 548 548
Lines 45599 45605 +6
Branches 6582 6578 -4
==========================================
+ Hits 43367 43384 +17
+ Misses 2102 2091 -11
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kennylam
approved these changes
May 5, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 5, 2026
c466ab9
54 of 55 checks passed
Contributor
|
Hey there! v11.107.0 was just released that references this issue/PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18992
Restored
Modallauncher focus forMenuButtonrefs.Changelog
Changed
Modallauncher focus forMenuButtonrefs.focusLauncherButton.Testing / Reviewing
yarn test packages/react/src/components/ModalPR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesMore details can be found in the pull request guide