feat: add support for TypeScript tests in @carbon/react#22150
Merged
heloiselui merged 5 commits intoMay 14, 2026
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22150 +/- ##
==========================================
- Coverage 95.49% 95.49% -0.01%
==========================================
Files 582 582
Lines 50320 50320
Branches 6742 6776 +34
==========================================
- Hits 48053 48052 -1
- Misses 2135 2136 +1
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2a79031 to
c7ac1a7
Compare
tay1orjones
reviewed
May 12, 2026
Comment on lines
+8
to
+10
| // TODO: Investigate whether migrating `config/jest-config-carbon` to | ||
| // TypeScript, or another similar change, would eliminate the need for these | ||
| // types. |
Member
There was a problem hiding this comment.
We can do this and do a one-off major/breaking change for that package if need be. We've done that before for the smaller config packages that have a reduced blast radius compared to the more mainstream packages where we don't do major version bumps.
tay1orjones
approved these changes
May 12, 2026
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
heloiselui
approved these changes
May 14, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 14, 2026
ebc609c
40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #16361
Closes #20439, we just need to put together some docs on how to repeat this on other components into #16361
Added support for TypeScript tests in
@carbon/react.Changelog
New
@carbon/react.Testing / Reviewing
I left the
TODOon the component in the test because there are issues in it and it's used by multiple tests. That issue is unrelated to the changes in this pull request, so I plan to follow-up on it in a future PR, someone thinks it should be addressed in this one.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide