Skip to content

fix(datepicker): add weekday to calendar aria-labels#22141

Merged
heloiselui merged 2 commits into
carbon-design-system:mainfrom
heloiselui:22044-datepicker-weekday-aria-label
Apr 30, 2026
Merged

fix(datepicker): add weekday to calendar aria-labels#22141
heloiselui merged 2 commits into
carbon-design-system:mainfrom
heloiselui:22044-datepicker-weekday-aria-label

Conversation

@heloiselui

@heloiselui heloiselui commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Closes #22044
Closes #15254

This PR updates the DatePicker calendar so screen readers announce the weekday with the full date. It keeps the same behavior in React and Web Components.

Changelog

New

  • None

Changed

  • Updated DatePicker day aria-labels to include the weekday
  • Added tests for React and Web Components

Removed

  • None

Testing / Reviewing

  • Go to the React and Web Components Deploy Preview > DatePicker > Default and Range with calendar
  • Turn on a screen reader, such as VoiceOver or JAWS
  • Tab to the input, then press Tab again to move to the current date
  • Check if announce the weekday, for example: Wednesday, April 29, 2026
image

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@heloiselui heloiselui requested a review from a team as a code owner April 29, 2026 16:34
@netlify

netlify Bot commented Apr 29, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d43ee03
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f233208100ac0008554679
😎 Deploy Preview https://deploy-preview-22141--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 29, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit d43ee03
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f233208100ac0008554677
😎 Deploy Preview https://deploy-preview-22141--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (0ba3f47) to head (d43ee03).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22141      +/-   ##
==========================================
- Coverage   95.08%   95.06%   -0.03%     
==========================================
  Files         541      541              
  Lines       45217    45225       +8     
  Branches     6560     6507      -53     
==========================================
- Hits        42996    42993       -3     
- Misses       2092     2103      +11     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.13% <100.00%> (+<0.01%) ⬆️
web-components 97.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@heloiselui heloiselui added this pull request to the merge queue Apr 30, 2026
Merged via the queue into carbon-design-system:main with commit afb89eb Apr 30, 2026
39 checks passed
@heloiselui heloiselui deleted the 22044-datepicker-weekday-aria-label branch April 30, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants