Skip to content

fix(PageHeader): deprecate components and docs, point to ibm-products#22120

Merged
sangeethababu9223 merged 11 commits into
carbon-design-system:mainfrom
tay1orjones:task/remove-pageheader-from-react
May 12, 2026
Merged

fix(PageHeader): deprecate components and docs, point to ibm-products#22120
sangeethababu9223 merged 11 commits into
carbon-design-system:mainfrom
tay1orjones:task/remove-pageheader-from-react

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #21926

Changelog

New

  • A codemod to migrate PageHeader imports from @carbon/react and @carbon/web-components to the IBM Products packages.
  • Put in a one-time React runtime deprecation warnings for PageHeader and its direct subcomponents, pointing consumers to IBM Products.
  • Added deprecation jsdoc comments across all relevant files

Changed

  • Replaced the PageHeader stories' content with a "deprecated" landing page, moved the MDX docs to a short “this has moved” message.

Testing / Reviewing

  • Make sure the stories look good and make sense, everything else should be covered by CI

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
    - [ ] Addressed any impact on accessibility (a11y)
    - [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7065f54
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6a0375469806410008bcaaff
😎 Deploy Preview https://deploy-preview-22120--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.06024% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.49%. Comparing base (bccb4fd) to head (7065f54).

Files with missing lines Patch % Lines
packages/upgrade/src/upgrades.js 0.00% 25 Missing and 1 partial ⚠️
packages/upgrade/src/cli.js 0.00% 2 Missing ⚠️
packages/upgrade/src/jscodeshift.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22120      +/-   ##
==========================================
- Coverage   95.52%   95.49%   -0.04%     
==========================================
  Files         582      582              
  Lines       50258    50320      +62     
  Branches     6772     6776       +4     
==========================================
+ Hits        48009    48051      +42     
- Misses       2118     2137      +19     
- Partials      131      132       +1
Flag Coverage Δ
main-packages 89.18% <29.26%> (-0.05%) ⬇️
web-components 98.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify

netlify Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7065f54
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6a03754629859d00098ea813
😎 Deploy Preview https://deploy-preview-22120--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@tay1orjones tay1orjones marked this pull request as ready for review April 27, 2026 20:44
@tay1orjones tay1orjones requested a review from a team as a code owner April 27, 2026 20:44
adamalston
adamalston reviewed Apr 29, 2026
View reviewed changes
Comment thread packages/upgrade/src/upgrades.js Outdated
@tay1orjones tay1orjones requested a review from adamalston April 30, 2026 20:55
adamalston
adamalston reviewed Apr 30, 2026
View reviewed changes
Comment thread packages/upgrade/src/cli.js
Comment thread packages/upgrade/transforms/ibm-products-update-page-header.js Outdated
@tay1orjones tay1orjones requested a review from adamalston May 4, 2026 16:46
adamalston
adamalston reviewed May 6, 2026
View reviewed changes
Comment thread packages/upgrade/src/upgrades.js
Comment thread packages/upgrade/transforms/ibm-products-update-page-header.js
@tay1orjones

tay1orjones commented May 8, 2026

Copy link
Copy Markdown
Member Author

Just some context - we're seeing a single use of this in our metric reporting tool. So we're probably looking at a single project consuming everything here.

@netlify

netlify Bot commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7065f54
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6a037546967c6400086a6476
😎 Deploy Preview https://deploy-preview-22120--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

emyarod
emyarod approved these changes May 11, 2026
View reviewed changes

@emyarod emyarod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@tay1orjones tay1orjones requested a review from adamalston May 11, 2026 17:21
sangeethababu9223
sangeethababu9223 approved these changes May 12, 2026
View reviewed changes

@sangeethababu9223 sangeethababu9223 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue May 12, 2026
Merged via the queue into carbon-design-system:main with commit 4ac71d0 May 12, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyarod emyarod emyarod approved these changes

@sangeethababu9223 sangeethababu9223 sangeethababu9223 approved these changes

@adamalston adamalston Awaiting requested review from adamalston

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate PageHeader in @carbon/react

4 participants

@tay1orjones @emyarod @adamalston @sangeethababu9223