fix(time-picker): announce invalid/warn state message#22109
Merged
heloiselui merged 3 commits intoApr 29, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22109 +/- ##
==========================================
+ Coverage 95.02% 95.06% +0.03%
==========================================
Files 538 541 +3
Lines 45028 45204 +176
Branches 6472 6535 +63
==========================================
+ Hits 42790 42972 +182
+ Misses 2109 2103 -6
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamalston
reviewed
Apr 26, 2026
tay1orjones
approved these changes
Apr 28, 2026
adamalston
approved these changes
Apr 29, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 29, 2026
d443e90
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19596
Fixed
TimePickera11y so invalid and warning messages are announced by screen readers.Changelog
New
NoneChanged
TimePickeraccessibility wiring soaria-describedbypoints to theinvalidtext when invalid is true andwarningtext when warning is truearia-describedbyvalues by merging them with the generated validation message IDaria-invalid="true"whenTimePickeris invalidTimePickerinvalid/warning, and mergedaria-describedbybehaviorRemoved
NoneTesting / Reviewing
React Deploy Preview>TimePicker>DefaultVoiceOverorJAWSinvalid to trueorwarning to trueandprovide invalidTextorprovide warningText, for exampleThis is test messagePR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Tested for cross-browser consistencyMore details can be found in the pull request guide