Skip to content

fix: fire ComboBox onChange on Tab selection#22007

Merged
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:19777-combo-box
Apr 30, 2026
Merged

fix: fire ComboBox onChange on Tab selection#22007
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:19777-combo-box

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Closes #19777

Fired ComboBox onChange on Tab selection.

Changelog

Changed

  • Fired ComboBox onChange on Tab selection.

Testing / Reviewing

yarn test packages/react/src/components/ComboBox/ComboBox-test.js

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cc09e41
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69dba592b208e50008c3c7a4
😎 Deploy Preview https://deploy-preview-22007--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cc09e41
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69dba59293dec600084a07a6
😎 Deploy Preview https://deploy-preview-22007--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (597001a) to head (cc09e41).
⚠️ Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22007      +/-   ##
==========================================
+ Coverage   94.90%   94.93%   +0.02%     
==========================================
  Files         541      541              
  Lines       45253    45254       +1     
  Branches     6359     6332      -27     
==========================================
+ Hits        42949    42961      +12     
+ Misses       2172     2161      -11     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.16% <100.00%> (+<0.01%) ⬆️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Adam!

@tay1orjones tay1orjones added this pull request to the merge queue Apr 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026
@heloiselui heloiselui added this pull request to the merge queue Apr 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026
@heloiselui heloiselui added this pull request to the merge queue Apr 30, 2026
Merged via the queue into carbon-design-system:main with commit a507191 Apr 30, 2026
55 checks passed
@adamalston adamalston deleted the 19777-combo-box branch April 30, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Combobox component highlights on selecting using tab but onChange() is not triggered

3 participants