fix: remove stale flatpickr DatePicker workarounds#22004
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22004 +/- ##
==========================================
+ Coverage 94.90% 94.93% +0.02%
==========================================
Files 541 541
Lines 45253 45238 -15
Branches 6359 6388 +29
==========================================
- Hits 42949 42945 -4
+ Misses 2172 2161 -11
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
riddhybansal
approved these changes
Apr 28, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 28, 2026
48a45d1
55 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue. #21836 (comment)
Removed stale
flatpickrDatePickerworkarounds.Changelog
Removed
flatpickrDatePickerworkarounds.Testing / Reviewing
Existing tests should cover these changes.
I deleted the flatpickr/flatpickr#1958 references from
packages/web-components/src/components/date-picker/range-plugin.ts. That file does not appear to override the upstreamrangePluginlogic tied to_prevDates,_secondInputFocused,onChange, oronValueUpdate, which is where the flatpickr/flatpickr#1958 behavior lives. The current wrapper only:allowInputis enabled.Keeping the flatpickr/flatpickr#1958 reference would imply that the file fixes behavior it does not currently change. Let me know if I'm missing something.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)More details can be found in the pull request guide