Skip to content

fix: ignore empty helperText across form controls#21995

Merged
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
adamalston:21992-helper-text
Apr 27, 2026
Merged

fix: ignore empty helperText across form controls#21995
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
adamalston:21992-helper-text

Conversation

@adamalston

@adamalston adamalston commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Closes #21992

Ignored empty helperText across form controls.

Changelog

Changed

  • Ignored empty helperText across form controls.

Testing / Reviewing

yarn test packages/react

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c458742
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69e65c5029f3ca000995022f
😎 Deploy Preview https://deploy-preview-21995--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c458742
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69e65c5196abcd0008c4102c
😎 Deploy Preview https://deploy-preview-21995--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (20a0076) to head (c458742).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21995   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         538      538           
  Lines       44982    44984    +2     
  Branches     6516     6482   -34     
=======================================
+ Hits        42740    42742    +2     
  Misses       2113     2113           
  Partials      129      129           
Flag Coverage Δ
main-packages 89.03% <100.00%> (+<0.01%) ⬆️
web-components 97.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26

Copy link
Copy Markdown
Contributor

@adamalston Some merge conflicts need to be resolved

@tay1orjones tay1orjones added this pull request to the merge queue Apr 27, 2026
Merged via the queue into carbon-design-system:main with commit 6898a87 Apr 27, 2026
39 checks passed
@adamalston adamalston deleted the 21992-helper-text branch April 27, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Helper text div is present altho helperText is empty

3 participants