Skip to content

feat: added xs size for pagination#21695

Merged
riddhybansal merged 13 commits into
carbon-design-system:mainfrom
riddhybansal:pagination_xs_size
Apr 30, 2026
Merged

feat: added xs size for pagination#21695
riddhybansal merged 13 commits into
carbon-design-system:mainfrom
riddhybansal:pagination_xs_size

Conversation

@riddhybansal

@riddhybansal riddhybansal commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Closes #21594

Added XS size for pagination component in react and webcomponents

Changelog

New

  • Added XS size for pagination component

Testing / Reviewing

Visit pagination
Set size prop to xs it should match as per the spec.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Mar 2, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 17a43dc
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f325eef21c070008d03355
😎 Deploy Preview https://deploy-preview-21695--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Mar 2, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 17a43dc
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f325ef5a766f0008675d47
😎 Deploy Preview https://deploy-preview-21695--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (cc54e3b) to head (17a43dc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21695      +/-   ##
==========================================
- Coverage   95.09%   95.06%   -0.03%     
==========================================
  Files         541      541              
  Lines       45235    45239       +4     
  Branches     6512     6512              
==========================================
- Hits        43015    43006       -9     
- Misses       2091     2104      +13     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.14% <ø> (ø)
web-components 97.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@riddhybansal riddhybansal marked this pull request as ready for review March 5, 2026 08:33
@riddhybansal riddhybansal requested a review from a team as a code owner March 5, 2026 08:33
Comment thread packages/web-components/src/components/pagination/pagination.scss Outdated

@devadula-nandan devadula-nandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

Comment thread packages/web-components/src/components/select/select.scss Outdated
@devadula-nandan

Copy link
Copy Markdown
Contributor

can you update the PR Checklist in the pr description?

@riddhybansal riddhybansal requested a review from a team as a code owner March 5, 2026 11:30

@alina-jacob alina-jacob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@devadula-nandan devadula-nandan self-requested a review March 9, 2026 12:44
Comment thread packages/styles/scss/components/pagination/_pagination.scss Outdated
Comment thread packages/react/src/components/Pagination/Pagination.tsx
Comment thread packages/web-components/src/components/pagination/defs.ts
@devadula-nandan

devadula-nandan commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Hi @riddhybansal,
As per the epic

Dev: Implement in both React and Web Components as well as connecting to the Contextual layout tokens. Question for Dev: Figma Code Connect?

Looks like the goal is to adopt contextual layout tokens into mentioned components?
as per the discussions in todays round robin, we might as well look into bringing the contextual layout token support into WC if not yet explored.

Please feel free to review the scope and determine whether we need to revisitContextual layout tokens later. and update the epic.

@riddhybansal

Copy link
Copy Markdown
Contributor Author

Marking as blocked since contextual layout tokens cannot be connected in Web Components since they have not been implemented yet.

@riddhybansal riddhybansal self-assigned this Apr 8, 2026
@github-project-automation github-project-automation Bot moved this to 🚦 In Review in Design System Apr 8, 2026
@riddhybansal riddhybansal moved this from 🚦 In Review to ⏱ Backlog in Design System Apr 8, 2026
@riddhybansal riddhybansal moved this from ⏱ Backlog to 🏗 In Progress in Design System Apr 28, 2026
@riddhybansal

Copy link
Copy Markdown
Contributor Author

Hi @devadula-nandan @sangeethababu9223 this is ready to review with additon of contextual tokens.

Comment thread packages/react/src/components/Pagination/Pagination.tsx Outdated

@sangeethababu9223 sangeethababu9223 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riddhybansal riddhybansal enabled auto-merge April 30, 2026 09:50
@riddhybansal riddhybansal added this pull request to the merge queue Apr 30, 2026
Merged via the queue into carbon-design-system:main with commit 1634ed2 Apr 30, 2026
38 checks passed
@riddhybansal riddhybansal deleted the pagination_xs_size branch April 30, 2026 10:51
@github-project-automation github-project-automation Bot moved this from 🚦 In Review to ✅ Done in Design System Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Condensed components] Pagination: Implementation

5 participants