chore(Tile): add controls args to every story#21612
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emyarod
left a comment
There was a problem hiding this comment.
looks good to me but you will need to accept the DCO to pass CI!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21612 +/- ##
==========================================
- Coverage 95.09% 95.06% -0.03%
==========================================
Files 541 541
Lines 45235 45235
Branches 6512 6512
==========================================
- Hits 43015 43002 -13
- Misses 2091 2104 +13
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have read the DCO document and I hereby sign the DCO. |
|
Hi @emyarod, |
sangeethababu9223
left a comment
There was a problem hiding this comment.
Hey @AFatmaa ,
Thanks for working on this, the story controls look great in the React stories!
When you get a chance, could you also take a look at the WC stories? The issue affects both @carbon/react and @carbon/web-components.
tay1orjones
left a comment
There was a problem hiding this comment.
LGTM, we can merge this as is and do a follow up for web components. I updated the PR body to be "part of" instead of "closes"
|
Hi @tay1orjones and @sangeethababu9223, Thanks for the review! I’ve updated the branch, and all tests are passing. Is there anything else needed from my side to get this PR merged? Let me know how you’d like me to proceed. Thank you! |
5bad7a3
Part of #20959
Adds controls args to every story of the tile component
Changelog
Changed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide