fiix(ComposedModal, Modal): ESC key handling breaks when Popover is open - DO NOT MERGE#21436
Closed
sangeethababu9223 wants to merge 7 commits into
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21436 +/- ##
==========================================
- Coverage 86.74% 86.73% -0.02%
==========================================
Files 539 539
Lines 42887 42916 +29
Branches 6602 6614 +12
==========================================
+ Hits 37203 37223 +20
- Misses 5518 5527 +9
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…odal-not-closing-on-outside-click
…odal-not-closing-on-outside-click
Member
Author
|
The fix for the onClickOutside functionality has been moved to a separate PR #21499 , since the Esc key issue requires further investigation. |
Member
Author
|
The interaction between Modal and Popover components requires further research, this PR will be closed for now. A new research issue will be created to investigate this in more detail. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19365
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add steps or a checklist for how reviewers can verify this PR works or not }}
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide