fix(a11y): use aria-errormessage for invalid text inputs#21297
Merged
heloiselui merged 9 commits intoMay 1, 2026
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21297 +/- ##
==========================================
- Coverage 95.08% 95.06% -0.02%
==========================================
Files 541 541
Lines 45217 45217
Branches 6560 6560
==========================================
- Hits 42996 42987 -9
- Misses 2092 2101 +9
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamalston
reviewed
Mar 7, 2026
adamalston
left a comment
Contributor
There was a problem hiding this comment.
Are there supposed to be test changes to accompany this fix? I'm wondering what the plan is for preventing regressions.
Contributor
Co-authored-by: Sangeetha Babu <sangeetha9223@gmail.com>
adamalston
reviewed
Apr 20, 2026
heloiselui
approved these changes
Apr 29, 2026
adamalston
approved these changes
May 1, 2026
Merged
via the queue into
carbon-design-system:main
with commit May 1, 2026
21677a1
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21247
Changelog
Changed
aria-errormessagefor error messages instead ofaria-describedbyTesting / Reviewing
aria-errormessageattribute pointing to error message IDaria-describedbywhen input is not invalidtoHaveAccessibleErrorMessage()assertion in PlaywrightPR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide