feat(NumberInput): updated locale format validation arabic japanese#21135
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21135 +/- ##
==========================================
+ Coverage 86.15% 86.16% +0.01%
==========================================
Files 535 535
Lines 41826 41893 +67
Branches 6460 6462 +2
==========================================
+ Hits 36035 36099 +64
- Misses 5627 5631 +4
+ Partials 164 163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@abpaul1993 Please update the |
|
@kennylam I have updated the PR details based on the feedback. |
…e-in-arabic-japanese
…e-in-arabic-japanese
heloiselui
left a comment
There was a problem hiding this comment.
Hi, thanks for your PR, I’ve left a few comments.
|
hi @heloiselui I have updated my code base as per your comments, please re review once. |
…e-in-arabic-japanese
…e-in-arabic-japanese
…e-in-arabic-japanese
72d196f
|
Hey there! v11.99.0 was just released that references this issue/PR. |
Closes #
This PR enhances our number parsing and validation logic to support all major Unicode numeral systems recognized by Intl.NumberFormat in validateNumberSeparators method along with the valid decimal and group seperator.
Previously, only Western digits were handled in the method.
With this update, the number input component now correctly accepts, validates, and normalizes numerals from multiple writing systems—matching real-world locale behavior across international users.
Changelog
New
Changed
Removed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide