fix: use correct enable-focus-wrap-without-sentinels flag name#21123
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21123 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 543 543
Lines 48465 48465
Branches 6737 6762 +25
=======================================
Hits 46232 46232
Misses 2108 2108
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
tay1orjones
left a comment
There was a problem hiding this comment.
IIRC in the past aria-hidden wasn't put on the sentinel nodes because they're technically still focusable and shouldn't be removed from the accessibility tree. There might be some past issue/discussions on the topic.
Ahh... yeah I'm missing any of that past discussion... and with the ability to use feature flags to get around the sentinel issue, should we just close this @tay1orjones? |
|
@jlongshore @tay1orjones I think we still want the updated feature flag naming you have here regardless even if we revert the aria-hidden change? |
enable-focus-wrap-without-sentinels flag name
|
Yes, I've updated this to remove the aria-hidden additions, leave the other, and also updated the original issue stating that using the flag is the intended way to "fix" to avoid the issue. |
70ce251
|
Hey there! v11.109.0 was just released that references this issue/PR. |
Closes #16389
This updates a few places we use enable-focus-wrap-without-sentinels and also the above issue now has a comment that the intended fix is to use the flag to avoid the issue.
Original (outdated) scope
Visually hidden link "Focus sentinel" is announced by the screen reader before notifications title and after close button.
Changelog
Changed
aria-hiddenproperties to visually hidden "Focus sentinel" elements.ComposedModal.featureflag.stories.jsandModal.featureflag.stories.js) referring to theenable-preview-focus-wrap-without-sentinelsfeature flag, which I couldn't find in the codebase, so I renamed toenable-focus-wrap-without-sentinels.Testing / Reviewing
aria-hidden, focus trapping appeared to work as beforePR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request guide