Skip to content

fix(code-connect): update package and fix component mappings#20545

Merged
alisonjoseph merged 15 commits into
carbon-design-system:mainfrom
alisonjoseph:code-connect-bugs
Sep 25, 2025
Merged

fix(code-connect): update package and fix component mappings#20545
alisonjoseph merged 15 commits into
carbon-design-system:mainfrom
alisonjoseph:code-connect-bugs

Conversation

@alisonjoseph

@alisonjoseph alisonjoseph commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Closes #20089

Changelog

Changed

  • update to latest version of code-connect package
  • minor updates to readme
  • Code connect fixes for the following components TreeNode, MultiSelect, DropdownSkeleton, FilterableMultiSelect, Dropdown, ComboBox, FluidMultiSelect, FluidFilterableMultiSelect, FluidComboBox, Breadcrumb, Tab
  • Commented out Tile and ProgressBar components causing errors. [Bug]: Code connect - validation failing for Tile and ProgressBar #20546

Testing / Reviewing

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
    Updated documentation and storybook examples
    Wrote passing tests that cover this change
    Addressed any impact on accessibility (a11y)
    Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@alisonjoseph alisonjoseph changed the title Code connect bugs fix(code-connect): update package and fix component mappings Sep 17, 2025
@netlify

netlify Bot commented Sep 17, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 31bbee6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68d571a3f5b77a0008b22f0d
😎 Deploy Preview https://deploy-preview-20545--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 17, 2025

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 31bbee6
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/68d571a3e1c56a0008a03d02
😎 Deploy Preview https://deploy-preview-20545--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 17, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 31bbee6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68d571a38535b10008f52813
😎 Deploy Preview https://deploy-preview-20545--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review September 17, 2025 16:26
@alisonjoseph alisonjoseph requested a review from a team as a code owner September 17, 2025 16:26
@alisonjoseph alisonjoseph requested review from a team, emyarod and heloiselui September 17, 2025 16:26
@codecov

codecov Bot commented Sep 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (30b4f87) to head (31bbee6).
⚠️ Report is 233 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20545      +/-   ##
==========================================
+ Coverage   91.39%   91.93%   +0.54%     
==========================================
  Files         485      484       -1     
  Lines       31370    32772    +1402     
  Branches     5430     5525      +95     
==========================================
+ Hits        28670    30130    +1460     
+ Misses       2547     2496      -51     
+ Partials      153      146       -7     
Flag Coverage Δ
main-packages 85.25% <ø> (+0.32%) ⬆️
web-components 97.25% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emyarod emyarod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@alisonjoseph alisonjoseph added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 25, 2025
@alisonjoseph alisonjoseph added this pull request to the merge queue Sep 25, 2025
Merged via the queue into carbon-design-system:main with commit 22c9d67 Sep 25, 2025
42 of 43 checks passed
@alisonjoseph alisonjoseph deleted the code-connect-bugs branch September 25, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Code Connect bugs

3 participants