fix(content-switcher): align web component with React for parity#19896
Merged
ariellalgilmore merged 22 commits intoAug 11, 2025
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19896 +/- ##
==========================================
+ Coverage 91.39% 91.53% +0.13%
==========================================
Files 485 479 -6
Lines 31370 31151 -219
Branches 5430 5464 +34
==========================================
- Hits 28670 28513 -157
+ Misses 2547 2488 -59
+ Partials 153 150 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 6, 2025
tay1orjones
approved these changes
Aug 8, 2025
ariellalgilmore
left a comment
Member
There was a problem hiding this comment.
few more updates, but almost there!!! thanks @heloiselui !
laurenmrice
approved these changes
Aug 8, 2025
laurenmrice
left a comment
Member
There was a problem hiding this comment.
This looks sooo good, great job @heloiselui !! ⭐️
I found a very small bug that is already happening in React and unrelated to this PR, so I made a separate issue for it.
heloiselui
commented
Aug 8, 2025
2nikhiltom
approved these changes
Aug 11, 2025
ariellalgilmore
approved these changes
Aug 11, 2025
Merged
via the queue into
carbon-design-system:main
with commit Aug 11, 2025
86e4af5
42 of 43 checks passed
6 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18319
Closes #19262
Closes Gui's PR #18815
Add React parity features to ContentSwitcher web component
Changelog
lowContrastmode and icon-only layouts in all sizes (sm,md,lg).cds-content-switcher-selectedto includeitem,index,name, andtext.disabledsupport tocds-content-switcher-item.selectedIndexandselectionModeproperties to control item selection programmatically.Changed
argTypesand controls for consistency with other components.selectionMode="manual".cds-content-switcherreflectsdisabledif any child is disabled.Removed
xlsize).Testing / Reviewing
WC Deploy Preview>Content Switcherstories:DefaultIcon OnlyIcon Only with LayerLow ContrastLow Contrast Icon OnlyWithLayerPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide