Skip to content

Unable to click SideNav inside HeaderContainer#14444

Merged
guidari merged 2 commits into
carbon-design-system:mainfrom
guidari:14414-sidenav
Aug 17, 2023
Merged

Unable to click SideNav inside HeaderContainer#14444
guidari merged 2 commits into
carbon-design-system:mainfrom
guidari:14414-sidenav

Conversation

@guidari

@guidari guidari commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Closes #14414

Added useMatchMedia to validate the screen size to adjust the inert attribute.

Testing / Reviewing

On the UIShell check if you can click in the SideNav items.

  • Header w/ SideNav
  • SideNav Rail w/ Header
  • Other variants...

@guidari guidari requested a review from a team as a code owner August 16, 2023 17:08
@netlify

netlify Bot commented Aug 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 7bb9943
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64de1948e68bfd000892a0b0
😎 Deploy Preview https://deploy-preview-14444--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Aug 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7bb9943
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64de1948082b1400082129a8
😎 Deploy Preview https://deploy-preview-14444--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! 👍 I totally forgot we had that hook

@guidari guidari added this pull request to the merge queue Aug 17, 2023
Merged via the queue into carbon-design-system:main with commit 5cf417c Aug 17, 2023
@guidari guidari deleted the 14414-sidenav branch August 17, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to click SideNav inside HeaderContainer

3 participants