fix(DataTable-BatchAction): resolve batch action button alignment#14384
Merged
Conversation
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO. |
Member
Author
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aagonzales
approved these changes
Aug 3, 2023
aagonzales
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for updating!
tw15egan
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14312
The TableBatchActions inside TableToolbar are misaligned for size variant 'sm'.
Changelog
Changed
padding-topandpadding-bottom) for 'sm' variant.Testing / Reviewing
checked manually through storybook.
https://deploy-preview-14384--carbon-components-react.netlify.app/?path=/story/components-datatable-batch-actions--playground&args=size:sm