fix(typescript): rename index.js to index.ts to expose some components#14358
Merged
tw15egan merged 2 commits intoAug 4, 2023
Merged
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14165
Changelog
Changed
index.jsfiles toindex.tsto make sure export statements innode_modules/@carbon/react/lib/index.d.tsof a TS React project can be resolved by the TypeScript compiler. (Reference: How TypeScript resolves modules)(Note: This PR renames
index.jsfiles that only reference TS files. There are still many components that cannot be imported in a TS project. Fixing the problem for all components in a single PR may lead to a huge PR which would be hard to test and review, so I only fix the easiest ones in this PR.)Testing / Reviewing
DatePickerInputby following the steps below.yarn buildnpx create-react-app test-carbon-import-ts --template typescript@carbon/react:npm i @carbon/reactcp -r /root/my-fork/carbon/packages/react/lib /root/tmp/test-carbon-import-ts/node_modules/@carbon/react/src/App.tsxin the new project and verify those components are imported correctly.