feat(Modal): add launcherButtonRef prop to handle focus on close#14355
Merged
Conversation
2 tasks
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Jul 31, 2023
andreancardona
left a comment
Contributor
There was a problem hiding this comment.
Other than the AVT test failing - looks good. I wonder if we can just specify that test to get it to pass?
Contributor
Author
|
@andreancardona updated the tests to account for the new behavior |
tay1orjones
approved these changes
Jul 31, 2023
tay1orjones
left a comment
Member
There was a problem hiding this comment.
Thanks for updating both Modal and ComposedModal 👍
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13680
Adds a new
launcherButtonReftoModalandComposedModal. This allows a user to pass in arefto the button that is used to launch theModalChangelog
New
launcherButtonRefprop added toModal/ComposedModal.Changed
launcherButtonRefprop to handle focus returning to the button when theModal/ComposedModalis closedTesting / Reviewing
Ensure focus returns to the button when closing either
Modal/ComposedModalvia keyboard or mouse click