Skip to content

fix(HeaderMenu): use composeEventHandlers in HeaderMenu#14353

Merged
tay1orjones merged 1 commit into
carbon-design-system:mainfrom
tw15egan:add-onclick-headermenu
Jul 31, 2023
Merged

fix(HeaderMenu): use composeEventHandlers in HeaderMenu#14353
tay1orjones merged 1 commit into
carbon-design-system:mainfrom
tw15egan:add-onclick-headermenu

Conversation

@tw15egan

@tw15egan tw15egan commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Refs #14311

Adds in composeEventHandlers so that user onClick, onBlur, and onKeyDown functions are respected

Changelog

Changed

  • Instead of only calling our event handlers, adds in the composeEventHandlers tool so that user events handlers are respected

Testing / Reviewing

Try passing an onClick with console.log to HeaderMenu. You should see your log

@tw15egan tw15egan requested a review from a team as a code owner July 31, 2023 16:57
@tw15egan tw15egan requested review from alisonjoseph and guidari July 31, 2023 16:57
@netlify

netlify Bot commented Jul 31, 2023

Copy link
Copy Markdown

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit a2b01f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c7e7f64cd80c0008058fef
😎 Deploy Preview https://deploy-preview-14353--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 31, 2023

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a2b01f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c7e7f61c99020008a0113b
😎 Deploy Preview https://deploy-preview-14353--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Jul 31, 2023
Merged via the queue into carbon-design-system:main with commit a679dae Jul 31, 2023
@tay1orjones tay1orjones mentioned this pull request Dec 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@guidari guidari Awaiting requested review from guidari guidari was automatically assigned from carbon-design-system/developers-system

+1 more reviewer

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tw15egan @alisonjoseph @tay1orjones