fix(Modal): ensure dropdown menu layer is correct#14303
Merged
tw15egan merged 3 commits intoAug 7, 2023
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Jul 25, 2023
alisonjoseph
approved these changes
Jul 25, 2023
laurenmrice
reviewed
Jul 26, 2023
laurenmrice
left a comment
Member
There was a problem hiding this comment.
Can you check to see what the other state color tokens are for the options in the dropdown inside of the modal? For the dark themes it looks like the hover and selected states are wrong.
Contributor
Author
|
@laurenmrice just added some more overrides to enforce those specific styles 👍🏻 |
laurenmrice
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13698
Refs #13258
Refs #13879
Ensures all listbox menus render the correct background color
Changelog
Changed
Testing / Reviewing
Ensure
Dropdownrenders the correct menu background when open