Skip to content

fix(DataTable): react event in getHeaderProps onClick and onInputChange#14286

Merged
tw15egan merged 3 commits into
carbon-design-system:mainfrom
dbrugger:datatable-event-types
Jul 28, 2023
Merged

fix(DataTable): react event in getHeaderProps onClick and onInputChange#14286
tw15egan merged 3 commits into
carbon-design-system:mainfrom
dbrugger:datatable-event-types

Conversation

@dbrugger

Copy link
Copy Markdown
Contributor

Types are not compatible for

  • getHeaderProps onClick
  • onInputChange

Changelog

Changed

  • use React event types in getHeaderProps onClick and onInputChange

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@dbrugger dbrugger requested a review from a team as a code owner July 22, 2023 17:03
@dbrugger dbrugger requested review from alisonjoseph and guidari July 22, 2023 17:03
@netlify

netlify Bot commented Jul 22, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ab7f897
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64bc0bd045636c000817d6d5
😎 Deploy Preview https://deploy-preview-14286--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 22, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ab7f897
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64bc0bd021c0cb0008151365
😎 Deploy Preview https://deploy-preview-14286--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 22, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit b2c0225
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c023a17aa78c0008257c7d
😎 Deploy Preview https://deploy-preview-14286--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 22, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b2c0225
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c023a170b638000744b3f7
😎 Deploy Preview https://deploy-preview-14286--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot enabled auto-merge July 25, 2023 19:34
@github-actions github-actions Bot added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 25, 2023
@tw15egan tw15egan added this pull request to the merge queue Jul 28, 2023
Merged via the queue into carbon-design-system:main with commit 3e133e7 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants