Skip to content

chore: updated next and react version in example#14219

Merged
guidari merged 6 commits into
carbon-design-system:mainfrom
guidari:update-next-version
Aug 1, 2023
Merged

chore: updated next and react version in example#14219
guidari merged 6 commits into
carbon-design-system:mainfrom
guidari:update-next-version

Conversation

@guidari

@guidari guidari commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

After working on this PR it was found a few errors when running an example using NextJS.

To fix that it was updated the next and react versions in the package.json for each example.

Changed

  • next and react version in package.json examples

Testing / Reviewing

Pull the branch locally and run the examples

@netlify

netlify Bot commented Jul 13, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ff75522
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c94cb13630a2000823fc6d
😎 Deploy Preview https://deploy-preview-14219--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 13, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ff75522
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c94cb1d15d2200070b9cce
😎 Deploy Preview https://deploy-preview-14219--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elements previews look good and the light-dark-mode example looks good.

The incremental-migration one is not working for me though
image

@guidari

guidari commented Jul 27, 2023

Copy link
Copy Markdown
Contributor Author

The incremental-migration one is not working for me though

Hey @tay1orjones I didn't find a way to fix that on NextJS. The example works outside of the monorepo, but not inside it, for some reason.

But I could fixed it by migrating the example to use Vite instead of NextJS. Check this Draft PR

My suggestion is to use that migration as an example to this issue, about how we can approach this transition.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks @guidari!

@github-actions github-actions Bot added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 1, 2023
@guidari guidari added this pull request to the merge queue Aug 1, 2023
Merged via the queue into carbon-design-system:main with commit 909f48d Aug 1, 2023
@guidari guidari deleted the update-next-version branch August 1, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants