fix(DataTable): fix a11y issues with selection variant#14206
Merged
kodiakhq[bot] merged 3 commits intoJul 13, 2023
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Jul 13, 2023
guidari
left a comment
Contributor
There was a problem hiding this comment.
Tested with VO and looks good!
francinelucca
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14053
Fixes an issue where an
aria-labelwas placed on alabelwith no role. Since no valid roles are available, I've moved the text from anaria-labelto be placed inside the label and visually hidden.Changelog
Changed
aria-label, usearia-labelto generate label text and hide itTesting / Reviewing
Go to DataTable w Selection story and run the a11y checker. Ensure there are no more violations and the functionality remains the same.