feat(ContainedList): fix a11y issues with story#14192
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@tw15egan Just chiming in from the design side: the use case of a tag displaying the number of items in a list was just used as one example of many possibilities of what could be shown in the header of a ContainedList. The design intent was essentially to just have a slot of fully customizable content. Some other use cases we've seen include:
I can share some designs via slack with the component in action that I can't post publicly. Maybe when building out the stories I should've been more clear of what is just an example use case and what is a locked down part of the component. I wonder how we could make that more clear, visually 🤔 |
c7f66da to
6c49e7e
Compare
|
@janhassel that makes sense! I wasn't sure if it was part of the spec, I can just fix the a11y violations and leave the component as is 👍🏻 thanks for confirming! |
Closes #13948
Adds an
aria-labelso theTagmakes more sense when using a screenreader and viewing theWith List Title DecoratorsstoryChangelog
New
aria-labeladded to story to give context toTagTesting / Reviewing
Enable your screenreader and ensure the
4has more context than simply announcing4