feat: tooltip keyboard testing#14159
Merged
tw15egan merged 57 commits intoJul 21, 2023
Merged
Conversation
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
…ancardona/carbon into contained-list-persistent-search-3
Co-authored-by: Francine Lucca <francinelucca@users.noreply.github.com>
… branch 'contained-list-persistent-search-3' of github.com:andreancardona/carbon into contained-list-persistent-search-3
tay1orjones
reviewed
Jul 19, 2023
guidari
approved these changes
Jul 20, 2023
…rbon into 14120-tooltip-keyboard
alisonjoseph
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13747
Closes #14120
Changelog
New
Broke @AVT tests out into their own Tooltip-test.avt.e2e.js file
@vrt tests remain in the Tooltip-test.e2e.js file
Add keyboard navigation tests covering default tooltip state
Update playwright config glob to match and include the new test file naming structure (avt.e2e.js)
Testing / Reviewing
CI should pass
Ensure the tests pass a sniff test and don't look problematic