fix(DataTableSkeleton): adjust TypeScript types to match behavior#14114
Merged
kodiakhq[bot] merged 5 commits intoJul 6, 2023
Merged
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Jul 5, 2023
guidari
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for contributing!
andreancardona
approved these changes
Jul 5, 2023
andreancardona
left a comment
Contributor
There was a problem hiding this comment.
Looks good thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeScript compilation errors such as the one below when using the DataTableSkeleton:
Changelog
Changed
Testing / Reviewing
Automated tests should pass. No behavior change should be seen in story book. DataTableSkeleton usage in TypeScript setup should follow component behavior.