feat(Tag): add as prop to Tag to specify wrapping element (#13959)#14112
Merged
kodiakhq[bot] merged 5 commits intoJul 6, 2023
Merged
Conversation
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
@tulivlk thanks for contributing! First off, to update snapshots, you'll need to run |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
tw15egan
approved these changes
Jul 6, 2023
tw15egan
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for contributing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13959
Added
asprop toTagcomponent, so the wrapping element can be changed from defaultdiv(orbuttonin case ofonClickprop is provided). Ifasis provided it overrides the logic of choosing betweendivorbutton, I consider that correct behaviour, but please revise.Changelog
New
asprop toTagcomponent