Skip to content

fix: update contained list search placeholder#14105

Merged
andreancardona merged 37 commits into
carbon-design-system:mainfrom
andreancardona:13944-contained-list-misleading-search-label
Jul 6, 2023
Merged

fix: update contained list search placeholder#14105
andreancardona merged 37 commits into
carbon-design-system:mainfrom
andreancardona:13944-contained-list-misleading-search-label

Conversation

@andreancardona

@andreancardona andreancardona commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

Closes #13944

Changelog

  • updates the placeholder text to be more descriptive for ContainedList - [with expandable & persistent search] from Search to Filterable search as confirmed with design

Testing / Reviewing

  • Make sure the following stories render the correct placeholder
  • Contained List: with Expandable Search
  • Contained List: with Persistent Search

tagging @kingtraceyj for visual review - thank you!

andreancardona and others added 30 commits March 31, 2023 10:43
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
…ancardona/carbon into contained-list-persistent-search-3
Co-authored-by: Francine Lucca <francinelucca@users.noreply.github.com>
… branch 'contained-list-persistent-search-3' of github.com:andreancardona/carbon into contained-list-persistent-search-3
@netlify

netlify Bot commented Jun 27, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 6c3e364
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a60025b3f26c00078d1ad0
😎 Deploy Preview https://deploy-preview-14105--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jun 27, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6c3e364
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a60025cb63910008cf3840
😎 Deploy Preview https://deploy-preview-14105--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kingtraceyj kingtraceyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go!

@andreancardona andreancardona enabled auto-merge (squash) July 5, 2023 23:43
@andreancardona andreancardona merged commit f7b7b4d into carbon-design-system:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: ContainedList - [with expandable & persistent search] - misleading search label

4 participants