Skip to content

fix(upgrade): add size prop codemods to upgrade package#14089

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
tw15egan:add-codemods-to-upgrade
Jun 27, 2023
Merged

fix(upgrade): add size prop codemods to upgrade package#14089
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
tw15egan:add-codemods-to-upgrade

Conversation

@tw15egan

Copy link
Copy Markdown
Contributor

Closes #14001

Adds in the 2 size codemods to @carbon/upgrade package

Changelog

New

  • size-prop-update and small-to-size-prop to @carbon/upgrade

Testing / Reviewing

Ensure it all builds properly. Not sure if we can test usage of something like npx @carbon/upgrade migrate small-to-size-prop until this is merged and a new version is released.

@tw15egan tw15egan requested a review from a team as a code owner June 26, 2023 14:13
@netlify

netlify Bot commented Jun 26, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8308b7a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/649af15b66ea340008af3042
😎 Deploy Preview https://deploy-preview-14089--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jun 26, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8308b7a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/649af15be78a600008099f93
😎 Deploy Preview https://deploy-preview-14089--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@francinelucca francinelucca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq Bot merged commit 90da4b9 into carbon-design-system:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Codemods cannot be ran from the upgrade CLI, size-prop-updates small-to-size-props

3 participants