Skip to content

fix(DataTable): fix padding issue with batch actions#14024

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
tw15egan:table-fix
Jun 19, 2023
Merged

fix(DataTable): fix padding issue with batch actions#14024
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
tw15egan:table-fix

Conversation

@tw15egan

Copy link
Copy Markdown
Contributor

Closes #14021

Fixes a padding issue with the DataTable batch action buttons

Changelog

Changed

  • Set a min-width on all icon button SVGs to prevent squishing
  • Set padding as only a left and right value as the rest is computed from the layout module

Testing / Reviewing

Go to Data Table with Batch Actions story, check a row, and ensure all action buttons line up properly

@netlify

netlify Bot commented Jun 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1523294
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6490970ceba9d30008709d25
😎 Deploy Preview https://deploy-preview-14024--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1523294
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6490970c0217c70008b8e612
😎 Deploy Preview https://deploy-preview-14024--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq Bot merged commit 1234cfd into carbon-design-system:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Buttons in data table batch actions misaligned

3 participants