fix(contained-list): explicitly set "list" role#14019
Merged
Merged
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Jun 16, 2023
francinelucca
approved these changes
Jun 19, 2023
francinelucca
left a comment
Contributor
There was a problem hiding this comment.
Confirmed can now hear the beginning and end of the list on iPhone VO 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13938
Ref: https://bugs.webkit.org/show_bug.cgi?id=170179#c1
Ref: https://developer.mozilla.org/en-US/docs/Web/CSS/list-style#accessibility_concerns
Changelog
Changed
role="list"toulTesting / Reviewing
Follow reproduction steps in #13938